Forráskód Böngészése

code review 支付问题

YunaiV 3 éve
szülő
commit
9a5f085369

+ 1 - 0
yudao-admin-server/src/main/java/cn/iocoder/yudao/adminserver/modules/pay/controller/app/PayAppController.java

@@ -109,6 +109,7 @@ public class PayAppController {
         // 得到所有的应用编号,查出所有的通道
         Collection<Long> payAppIds = CollectionUtils.convertList(pageResult.getList(), PayAppDO::getId);
         List<PayChannelDO> channels = channelService.getChannelListByAppIds(payAppIds);
+        // TODO @aquan:可以基于 appId 简历一个 multiMap。这样下面,直接 get 到之后,CollUtil buildSet 即可
         Iterator<PayChannelDO> iterator = channels.iterator();
 
         // 得到所有的商户信息

+ 1 - 2
yudao-admin-server/src/main/java/cn/iocoder/yudao/adminserver/modules/pay/service/app/impl/PayAppServiceImpl.java

@@ -181,10 +181,9 @@ public class PayAppServiceImpl implements PayAppService {
             throw exception(PAY_APP_EXIST_TRANSACTION_ORDER_CANT_DELETE);
         }
         // 查看退款订单
-        if (refundMapper.selectCount(appId,   PayRefundStatusEnum.CREATE.getStatus()) > 0) {
+        if (refundMapper.selectCount(appId, PayRefundStatusEnum.CREATE.getStatus()) > 0) {
             throw exception(PAY_APP_EXIST_TRANSACTION_ORDER_CANT_DELETE);
         }
-
     }
 
 }