Browse Source

code review ProjectReactor 的代码实现

YunaiV 3 years ago
parent
commit
5ac7c3bd5d
1 changed files with 5 additions and 5 deletions
  1. 5 5
      yudao-server/src/test/java/cn/iocoder/yudao/ProjectReactor.java

+ 5 - 5
yudao-server/src/test/java/cn/iocoder/yudao/ProjectReactor.java

@@ -31,7 +31,7 @@ public class ProjectReactor {
         String projectBaseDir = getProjectBaseDir();
         String projectBaseDir = getProjectBaseDir();
 
 
         // ========== 配置,需要你手动修改 ==========
         // ========== 配置,需要你手动修改 ==========
-        String groupIdNew = "cn.huwing.boot";
+        String groupIdNew = "cn.huwing.boot"; // TODO @seeker:这几个参数改回去原来的哈。
         String artifactIdNew = "zdm";
         String artifactIdNew = "zdm";
         String packageNameNew = "cn.huwing.zdm";
         String packageNameNew = "cn.huwing.zdm";
         String titleNew = "测试名管理系统";
         String titleNew = "测试名管理系统";
@@ -47,8 +47,8 @@ public class ProjectReactor {
             String content = replaceFileContent(file, groupIdNew, artifactIdNew, packageNameNew, titleNew);
             String content = replaceFileContent(file, groupIdNew, artifactIdNew, packageNameNew, titleNew);
             writeFile(file, content, projectBaseDir, projectBaseDirNew, packageNameNew, artifactIdNew);
             writeFile(file, content, projectBaseDir, projectBaseDirNew, packageNameNew, artifactIdNew);
         });
         });
-        long end = System.currentTimeMillis();
-        log.info("[main][重写完成]共耗时:" + (end - start) / 1000 + "秒");
+        long end = System.currentTimeMillis(); // TODO @seeker:直接减,不用增加变量
+        log.info("[main][重写完成]共耗时:" + (end - start) / 1000 + "秒"); // TODO @seeker:logger 不要拼接字符串,用占位符
     }
     }
 
 
     private static String getProjectBaseDir() {
     private static String getProjectBaseDir() {
@@ -59,7 +59,7 @@ public class ProjectReactor {
         Collection<File> files = FileUtils.listFiles(new File(projectBaseDir), null, true);
         Collection<File> files = FileUtils.listFiles(new File(projectBaseDir), null, true);
         // 移除 IDEA  Git GitHub 自身的文件; Node 编译出来的文件
         // 移除 IDEA  Git GitHub 自身的文件; Node 编译出来的文件
         files = files.stream()
         files = files.stream()
-                .filter(file -> !file.getPath().contains("\\target\\")
+                .filter(file -> !file.getPath().contains("\\target\\") // TODO @seeker:使用 File.separator,也要考虑 mac
                         && !file.getPath().contains("\\node_modules\\")
                         && !file.getPath().contains("\\node_modules\\")
                         && !file.getPath().contains("\\.idea\\")
                         && !file.getPath().contains("\\.idea\\")
                         && !file.getPath().contains("\\.git\\")
                         && !file.getPath().contains("\\.git\\")
@@ -91,4 +91,4 @@ public class ProjectReactor {
                 .replaceAll(StrUtil.upperFirst(ARTIFACT_ID), StrUtil.upperFirst(artifactIdNew));
                 .replaceAll(StrUtil.upperFirst(ARTIFACT_ID), StrUtil.upperFirst(artifactIdNew));
         FileUtil.writeUtf8String(fileContent, newPath);
         FileUtil.writeUtf8String(fileContent, newPath);
     }
     }
-}
+}