Bladeren bron

!892 修补会员取消售后接口中未校验用户ID的安全漏洞
Merge pull request !892 from 杨宇庆/N/A

芋道源码 1 jaar geleden
bovenliggende
commit
556e3786a8

+ 1 - 1
yudao-module-mall/yudao-module-trade-biz/src/main/java/cn/iocoder/yudao/module/trade/service/aftersale/AfterSaleServiceImpl.java

@@ -383,7 +383,7 @@ public class AfterSaleServiceImpl implements AfterSaleService {
     @AfterSaleLog(operateType = AfterSaleOperateTypeEnum.MEMBER_CANCEL)
     @AfterSaleLog(operateType = AfterSaleOperateTypeEnum.MEMBER_CANCEL)
     public void cancelAfterSale(Long userId, Long id) {
     public void cancelAfterSale(Long userId, Long id) {
         // 校验售后单的状态,并状态待退款
         // 校验售后单的状态,并状态待退款
-        AfterSaleDO afterSale = tradeAfterSaleMapper.selectById(id);
+        AfterSaleDO afterSale = tradeAfterSaleMapper.selectByIdAndUserId(id, userId);
         if (afterSale == null) {
         if (afterSale == null) {
             throw exception(AFTER_SALE_NOT_FOUND);
             throw exception(AFTER_SALE_NOT_FOUND);
         }
         }