|
@@ -1,20 +1,20 @@
|
|
package cn.iocoder.yudao.module.member.service.signin;
|
|
package cn.iocoder.yudao.module.member.service.signin;
|
|
|
|
|
|
-import cn.iocoder.yudao.module.member.service.signin.MemberSignInConfigService;
|
|
|
|
-import org.springframework.stereotype.Service;
|
|
|
|
-import javax.annotation.Resource;
|
|
|
|
-import org.springframework.validation.annotation.Validated;
|
|
|
|
-
|
|
|
|
-import java.util.*;
|
|
|
|
-import cn.iocoder.yudao.module.member.controller.admin.signin.vo.*;
|
|
|
|
-import cn.iocoder.yudao.module.member.dal.dataobject.signin.MemberSignInConfigDO;
|
|
|
|
import cn.iocoder.yudao.framework.common.pojo.PageResult;
|
|
import cn.iocoder.yudao.framework.common.pojo.PageResult;
|
|
-
|
|
|
|
|
|
+import cn.iocoder.yudao.module.member.controller.admin.signin.vo.MemberSignInConfigCreateReqVO;
|
|
|
|
+import cn.iocoder.yudao.module.member.controller.admin.signin.vo.MemberSignInConfigPageReqVO;
|
|
|
|
+import cn.iocoder.yudao.module.member.controller.admin.signin.vo.MemberSignInConfigUpdateReqVO;
|
|
import cn.iocoder.yudao.module.member.convert.signin.MemberSignInConfigConvert;
|
|
import cn.iocoder.yudao.module.member.convert.signin.MemberSignInConfigConvert;
|
|
|
|
+import cn.iocoder.yudao.module.member.dal.dataobject.signin.MemberSignInConfigDO;
|
|
import cn.iocoder.yudao.module.member.dal.mysql.signin.MemberSignInConfigMapper;
|
|
import cn.iocoder.yudao.module.member.dal.mysql.signin.MemberSignInConfigMapper;
|
|
|
|
+import org.springframework.stereotype.Service;
|
|
|
|
+import org.springframework.validation.annotation.Validated;
|
|
|
|
+
|
|
|
|
+import javax.annotation.Resource;
|
|
|
|
|
|
import static cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil.exception;
|
|
import static cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil.exception;
|
|
-import static cn.iocoder.yudao.module.member.enums.ErrorCodeConstants.*;
|
|
|
|
|
|
+import static cn.iocoder.yudao.module.member.enums.ErrorCodeConstants.SIGN_IN_CONFIG_EXISTS;
|
|
|
|
+import static cn.iocoder.yudao.module.member.enums.ErrorCodeConstants.SIGN_IN_CONFIG_NOT_EXISTS;
|
|
|
|
|
|
/**
|
|
/**
|
|
* 积分签到规则 Service 实现类
|
|
* 积分签到规则 Service 实现类
|
|
@@ -28,17 +28,19 @@ public class MemberSignInConfigServiceImpl implements MemberSignInConfigService
|
|
@Resource
|
|
@Resource
|
|
private MemberSignInConfigMapper memberSignInConfigMapper;
|
|
private MemberSignInConfigMapper memberSignInConfigMapper;
|
|
|
|
|
|
|
|
+ // TODO @xiaqing:这种写的逻辑,最好按照 校验 - 更新这样的顺序写;类似这里,37 要放到 34 前面;updateSignInConfig 也是一样的思路
|
|
@Override
|
|
@Override
|
|
public Integer createSignInConfig(MemberSignInConfigCreateReqVO createReqVO) {
|
|
public Integer createSignInConfig(MemberSignInConfigCreateReqVO createReqVO) {
|
|
// 插入
|
|
// 插入
|
|
MemberSignInConfigDO signInConfig = MemberSignInConfigConvert.INSTANCE.convert(createReqVO);
|
|
MemberSignInConfigDO signInConfig = MemberSignInConfigConvert.INSTANCE.convert(createReqVO);
|
|
- //判断是否重复插入签到天数
|
|
|
|
|
|
+ // 判断是否重复插入签到天数
|
|
validateSignInConfigExistsDay(signInConfig.getDay());
|
|
validateSignInConfigExistsDay(signInConfig.getDay());
|
|
memberSignInConfigMapper.insert(signInConfig);
|
|
memberSignInConfigMapper.insert(signInConfig);
|
|
// 返回
|
|
// 返回
|
|
return signInConfig.getId();
|
|
return signInConfig.getId();
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+ // TODO @xiaqing:这个逻辑的空行要注意;52 到 53 是没必要的空行;而 49 和 50 之间有个空行会好点,可以区分出是 校验 - 更新这样的逻辑间隔
|
|
@Override
|
|
@Override
|
|
public void updateSignInConfig(MemberSignInConfigUpdateReqVO updateReqVO) {
|
|
public void updateSignInConfig(MemberSignInConfigUpdateReqVO updateReqVO) {
|
|
// 校验存在
|
|
// 校验存在
|
|
@@ -65,6 +67,8 @@ public class MemberSignInConfigServiceImpl implements MemberSignInConfigService
|
|
throw exception(SIGN_IN_CONFIG_NOT_EXISTS);
|
|
throw exception(SIGN_IN_CONFIG_NOT_EXISTS);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
+
|
|
|
|
+ // TODO @xiaqing:这个唯一判断,也可以参考下别的模块哈;
|
|
//根据签到天数判断是否存在一个相同的天数
|
|
//根据签到天数判断是否存在一个相同的天数
|
|
private void validateSignInConfigExistsDay(Integer day) {
|
|
private void validateSignInConfigExistsDay(Integer day) {
|
|
if (memberSignInConfigMapper.selectCount(MemberSignInConfigDO::getDay,day)>0) {
|
|
if (memberSignInConfigMapper.selectCount(MemberSignInConfigDO::getDay,day)>0) {
|
|
@@ -72,32 +76,22 @@ public class MemberSignInConfigServiceImpl implements MemberSignInConfigService
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
- //更新天数时判断是否有重复的天数,需要去除自己
|
|
|
|
|
|
+ // TODO @xiaqing:参考下别的模块,判断唯一,排除自己怎么写的哈;
|
|
|
|
+ // 更新天数时判断是否有重复的天数,需要去除自己
|
|
private void validateSignInConfigSameDayNotSelf(MemberSignInConfigUpdateReqVO reqVO) {
|
|
private void validateSignInConfigSameDayNotSelf(MemberSignInConfigUpdateReqVO reqVO) {
|
|
if (memberSignInConfigMapper.selectSameDayNotSelf(reqVO)>0) {
|
|
if (memberSignInConfigMapper.selectSameDayNotSelf(reqVO)>0) {
|
|
throw exception(SIGN_IN_CONFIG_EXISTS);
|
|
throw exception(SIGN_IN_CONFIG_EXISTS);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
-
|
|
|
|
@Override
|
|
@Override
|
|
public MemberSignInConfigDO getSignInConfig(Integer id) {
|
|
public MemberSignInConfigDO getSignInConfig(Integer id) {
|
|
return memberSignInConfigMapper.selectById(id);
|
|
return memberSignInConfigMapper.selectById(id);
|
|
}
|
|
}
|
|
|
|
|
|
- @Override
|
|
|
|
- public List<MemberSignInConfigDO> getSignInConfigList(Collection<Integer> ids) {
|
|
|
|
- return memberSignInConfigMapper.selectBatchIds(ids);
|
|
|
|
- }
|
|
|
|
-
|
|
|
|
@Override
|
|
@Override
|
|
public PageResult<MemberSignInConfigDO> getSignInConfigPage(MemberSignInConfigPageReqVO pageReqVO) {
|
|
public PageResult<MemberSignInConfigDO> getSignInConfigPage(MemberSignInConfigPageReqVO pageReqVO) {
|
|
return memberSignInConfigMapper.selectPage(pageReqVO);
|
|
return memberSignInConfigMapper.selectPage(pageReqVO);
|
|
}
|
|
}
|
|
|
|
|
|
- @Override
|
|
|
|
- public List<MemberSignInConfigDO> getSignInConfigList(MemberSignInConfigExportReqVO exportReqVO) {
|
|
|
|
- return memberSignInConfigMapper.selectList(exportReqVO);
|
|
|
|
- }
|
|
|
|
-
|
|
|
|
}
|
|
}
|